DBP-645-privac-idea-fix-for-server-resource #24

aimee-889 · 2024-03-01T11:09:48Z

Description

the terraform resource requires that ssk_keys are set for initial setup (we ignore the ssh_keys after setup)
should get tagged as 4.7
add output of dns name

All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

modules/ionos-basic-vm/outputs.tf

fix missing ssh_key for ionos server resource

bdf6daf

aimee-889 self-assigned this Mar 1, 2024

aimee-889 requested a review from maxi418 March 1, 2024 11:14

aimee-889 and others added 2 commits March 4, 2024 06:45

add dns name to outputs of basic vm module

c405c90

terraform-docs: automated action

e355345

aimee-889 changed the title ~~fix missing ssh_key for ionos server resource~~ DBP-645-privac-idea-fix-for-server-resource Mar 4, 2024

aimee-889 requested a review from a team March 4, 2024 09:00

simoncolincap reviewed Mar 4, 2024

View reviewed changes

modules/ionos-basic-vm/outputs.tf Outdated Show resolved Hide resolved

aimee-889 added 2 commits March 6, 2024 08:44

test expression without join

01f111f

simplify expression

4f6cb6d

aimee-889 requested a review from simoncolincap March 6, 2024 07:54

simoncolincap approved these changes Mar 6, 2024

View reviewed changes

aimee-889 merged commit 459657f into main Mar 6, 2024
2 checks passed

aimee-889 deleted the DBP-645-privac-idea-fix-for-server-resource branch March 6, 2024 10:02